fix: License breaks helm chart #591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix apache/incubator-answer\apache#590
|
I was mistaken. The same thing goes for the hpa, pvc and ingress. They are also conditional are are giving the same errors |
LinuxSuRen
reviewed
Nov 20, 2023
LinuxSuRen
left a comment
LinuxSuRen
left a comment
There was a problem hiding this comment.
I'm wondering if it's possible to have a way to test aginst it automatically. For example, doing a lint or a dry run something.
|
By the way, test the Helm chart via e2e testing might be a good choice. During the e2e testing, it can install the Helm in k3s or other small Kubernetes distribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #590