use Unicode glyphs or SVG data URLs instead of bitmaps #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaikiran
reviewed
Aug 31, 2017
build-release.xml
Outdated
| @@ -179,11 +180,11 @@ | |||
| </target> | |||
|
|
|||
| <target name="init-asciidoctor" depends="init-asciidoctor-extensions" unless="skip.doc"> | |||
| <ivy:cachepath pathid="asciidoctor.path" organisation="org.asciidoctor" module="asciidoctor-ant" revision="1.5.4" inline="true"/> | |||
| <ivy:cachepath pathid="asciidoctor.path" organisation="org.asciidoctor" module="asciidoctor-ant" revision="1.5.3" conf="default" inline="true"/> | |||
| <taskdef uri="antlib:org.asciidoctor.ant" resource="org/asciidoctor/ant/antlib.xml" classpathref="asciidoctor.path"> | |||
There was a problem hiding this comment.
Instead of downgrading the version, I think we should try and figure out whatever the issue is with 1.5.4
There was a problem hiding this comment.
Very well, here's the output from 1.5.4:
.../ant-ivy/build-release.xml:202: org.jruby.exceptions.RaiseException: (LoadError) no such file to load -- asciidoctor
at org.jruby.RubyKernel.require(org/jruby/RubyKernel.java:1040)
at RUBY.require(.../.ivy2/cache/org.asciidoctor/asciidoctor-ant/jars/asciidoctor-ant-1.5.4.jar!/META-INF/jruby.home/lib/ruby/shared/rubygems/core_ext/kernel_require.rb:54)
at RUBY.(root)(<script>:9)
|
I changed back the version of asciidoctor-ant to 1.5.4 and added a stab at IVY-450. The current description does not indicate what should happen when the parent is collapsed, so I assume that one may as well use breadcrumbs rather than visual cues from the menu. |
|
Looks like I've beaten time to first response record again: 90000+ hours 😃 |
twogee
force-pushed
the
master
branch
2 times, most recently
from
a9bf1d6 to
07f1201
Compare
twogee
force-pushed
the
master
branch
3 times, most recently
from
182c762 to
4e10a57
Compare
twogee
force-pushed
the
master
branch
2 times, most recently
from
0857684 to
6fd4c04
Compare
twogee
force-pushed
the
master
branch
4 times, most recently
from
3f33822 to
c6f1a08
Compare
twogee
force-pushed
the
master
branch
5 times, most recently
from
30d8dbd to
333f3ce
Compare
twogee
force-pushed
the
master
branch
7 times, most recently
from
9968324 to
a4aca0c
Compare
twogee
force-pushed
the
master
branch
2 times, most recently
from
f5a7a5a to
e472429
Compare
twogee
force-pushed
the
master
branch
2 times, most recently
from
f7a67ee to
1bbfedc
Compare
twogee
force-pushed
the
master
branch
2 times, most recently
from
53814bb to
f1d1841
Compare
twogee
force-pushed
the
master
branch
3 times, most recently
from
847674f to
2ee9961
Compare
twogee
force-pushed
the
master
branch
2 times, most recently
from
d27ecf7 to
c783c48
Compare
twogee
force-pushed
the
master
branch
2 times, most recently
from
22095c1 to
f12b9b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I put this up for review in case I missed some page that used the removed icons.