Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makefile: for make release-src, it should release the source code #787

Closed
membphis opened this issue Nov 11, 2020 · 5 comments
Closed

makefile: for make release-src, it should release the source code #787

membphis opened this issue Nov 11, 2020 · 5 comments
Assignees
Labels

Comments

@membphis
Copy link
Member

https://github.com/apache/apisix-dashboard/blob/v2.0/Makefile#L93

that is wrong, for make release-src, it should release the source code.

but we released binary file now, this is wrong.

.PHONY: release-src
release-src:
	tar –cf dashboard.tar ./output/*
@membphis
Copy link
Member Author

membphis commented Nov 11, 2020

@gxthrj you can take a look at this issue

@gxthrj
Copy link
Contributor

gxthrj commented Nov 12, 2020

ok, we can call it make release,the release package contains the binary file of manager-api and static files of web.

@gxthrj gxthrj self-assigned this Nov 12, 2020
@juzhiyuan
Copy link
Member

make-release is more semantic and clearer.

gxthrj added a commit to gxthrj/incubator-apisix-dashboard that referenced this issue Nov 15, 2020
@gxthrj
Copy link
Contributor

gxthrj commented Nov 17, 2020

@membphis Can we close this issue now?
The document has changed the original purpose of packaging the output directory.
make release-src is for source release now. #816

@juzhiyuan
Copy link
Member

We could close this one IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants