Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: manager-api do not support add consumer with custom create time or update time #851

Closed
idbeta opened this issue Nov 23, 2020 · 10 comments

Comments

@idbeta
Copy link
Contributor

idbeta commented Nov 23, 2020

Bug report

Describe the bug

use manager-api add a consumer with custom create time or update time,
but the consumer actually created does not use the custom time.

@idbeta idbeta added the bug Something isn't working label Nov 23, 2020
@idbeta idbeta changed the title bug: manager-api do not support consumer with custom create time or update time bug: manager-api do not support add consumer with custom create time or update time Nov 23, 2020
@starsz
Copy link
Contributor

starsz commented Nov 23, 2020

Hi, @idbeta, I can't get your point.
Can you give me an example or steps to reproduce the issue?

idbeta added a commit to idbeta/apisix-dashboard that referenced this issue Nov 23, 2020
@idbeta
Copy link
Contributor Author

idbeta commented Nov 23, 2020

@starsz
Copy link
Contributor

starsz commented Nov 23, 2020

OK, I reproduce the issue.

@ShiningRush
Copy link
Contributor

ShiningRush commented Nov 24, 2020

I don't think it is a bug, audit field should maintain by server not client.So we should not accept client audit field such as CreatedAt, CreatedBy etc.

@juzhiyuan
Copy link
Member

Not sure if it's a bug indeed, what's your opinion? I would be more prefer with @ShiningRush's opinion 🤔

cc @membphis @nic-chen @liuxiran @tokers

@liuxiran
Copy link
Contributor

I don't think it is a bug, audit field should maintain by server not client.So we should not accept client audit field such as CreatedAt, CreatedBy etc.

agree +1.
If the user customizes these fields, it goes against the original intent of using these fields to record the time.

@juzhiyuan juzhiyuan removed bug Something isn't working checking labels Nov 24, 2020
@juzhiyuan juzhiyuan added this to the 2.2 milestone Nov 24, 2020
@nic-chen
Copy link
Member

I don't think it is a bug, audit field should maintain by server not client.So we should not accept client audit field such as CreatedAt, CreatedBy etc.

agree +1

@starsz
Copy link
Contributor

starsz commented Nov 25, 2020

OK. So the conclusion is that we should not accept the client audit fields such as CreatedAt, CreatedBy.
If the client put those fields, just ignore them.

@juzhiyuan
Copy link
Member

Should we add this tip to FAQ?

@idbeta
Copy link
Contributor Author

idbeta commented Nov 25, 2020

At the beginning, I referred to the processing of adminAPI ( APISIX ). After reading your comments, I think manager-api does not need to be the same as adminAPI at this point. I will modify the related test cases.

@idbeta idbeta closed this as completed Nov 25, 2020
idbeta added a commit to idbeta/apisix-dashboard that referenced this issue Nov 25, 2020
add new case about update consumer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants