Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support IP allow list #1424

Merged
merged 7 commits into from
Feb 5, 2021
Merged

Conversation

nic-chen
Copy link
Member

@nic-chen nic-chen commented Feb 4, 2021

Please answer these questions before submitting a pull request


New feature or improvement

  • Describe the details and related test reports.

support IP allow list for Manager API

api/internal/conf/conf.go Outdated Show resolved Hide resolved
Copy link
Contributor

@starsz starsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add cli test for this PR?

api/internal/filter/ip_filter.go Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Feb 5, 2021

Codecov Report

Merging #1424 (7be3fe4) into master (9824b5f) will decrease coverage by 10.40%.
The diff coverage is 51.21%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1424       +/-   ##
===========================================
- Coverage   67.08%   56.67%   -10.41%     
===========================================
  Files          46       48        +2     
  Lines        2947     3010       +63     
===========================================
- Hits         1977     1706      -271     
- Misses        731     1027      +296     
- Partials      239      277       +38     
Impacted Files Coverage Δ
api/internal/filter/ip_filter.go 48.71% <48.71%> (ø)
api/internal/conf/conf.go 71.92% <100.00%> (+0.50%) ⬆️
api/internal/route.go 85.29% <100.00%> (ø)
api/internal/handler/plugin/plugin.go 16.66% <0.00%> (-70.00%) ⬇️
api/internal/core/store/query.go 45.23% <0.00%> (-52.39%) ⬇️
api/internal/core/store/selector.go 35.18% <0.00%> (-51.86%) ⬇️
api/internal/core/store/validate_mock.go 0.00% <0.00%> (-50.00%) ⬇️
api/internal/filter/authentication.go 41.66% <0.00%> (-34.81%) ⬇️
api/internal/core/store/store.go 58.43% <0.00%> (-28.24%) ⬇️
api/internal/handler/global_rule/global_rule.go 64.51% <0.00%> (-19.36%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9824b5f...7be3fe4. Read the comment docs.

@imjoey
Copy link
Member

imjoey commented Feb 5, 2021

@nic-chen This is a great and useful feature for users. How about add relevant docs in user guide? Thanks.

@imjoey
Copy link
Member

imjoey commented Feb 5, 2021

@nic-chen This is a great and useful feature for users. How about add relevant docs in user guide? Thanks.

we could merge this first and then add docs in another PR. what's you opinions? @nic-chen @juzhiyuan @starsz

Copy link
Member

@imjoey imjoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@starsz
Copy link
Contributor

starsz commented Feb 5, 2021

@nic-chen This is a great and useful feature for users. How about add relevant docs in user guide? Thanks.

we could merge this first and then add docs in another PR. what's you opinions? @nic-chen @juzhiyuan @starsz

Agree with it.
Maybe we can support the blacklist. 😄

@nic-chen
Copy link
Member Author

nic-chen commented Feb 5, 2021

@nic-chen This is a great and useful feature for users. How about add relevant docs in user guide? Thanks.

we could merge this first and then add docs in another PR. what's you opinions? @nic-chen @juzhiyuan @starsz

Thanks, I will create an issue to track it.

@nic-chen nic-chen merged commit 42f3bf6 into apache:master Feb 5, 2021
@juzhiyuan
Copy link
Member

ok

@nic-chen nic-chen deleted the ip-allowed-list branch February 5, 2021 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: support IP restriction
6 participants