-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support IP allow list #1424
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add cli test for this PR?
Codecov Report
@@ Coverage Diff @@
## master #1424 +/- ##
===========================================
- Coverage 67.08% 56.67% -10.41%
===========================================
Files 46 48 +2
Lines 2947 3010 +63
===========================================
- Hits 1977 1706 -271
- Misses 731 1027 +296
- Partials 239 277 +38
Continue to review full report at Codecov.
|
@nic-chen This is a great and useful feature for users. How about add relevant docs in user guide? Thanks. |
we could merge this first and then add docs in another PR. what's you opinions? @nic-chen @juzhiyuan @starsz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Agree with it. |
Thanks, I will create an issue to track it. |
ok |
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Backport patches
Related issues
close feature: support IP restriction #680
New feature or improvement
support IP allow list for Manager API