feat: support plugin config #1509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starsz
reviewed
Feb 25, 2021
Codecov Report
@@ Coverage Diff @@
## master #1509 +/- ##
==========================================
- Coverage 70.12% 62.09% -8.03%
==========================================
Files 129 130 +1
Lines 5231 5340 +109
Branches 549 549
==========================================
- Hits 3668 3316 -352
- Misses 1323 1723 +400
- Partials 240 301 +61
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
starsz
reviewed
Mar 1, 2021
nic-chen
requested review from
imjoey,
gxthrj,
spacewander,
ShiningRush,
tokers and
starsz
and removed request for
imjoey,
spacewander,
gxthrj,
tokers and
ShiningRush
starsz
reviewed
Mar 2, 2021
| Headers: map[string]string{"Authorization": base.GetToken()}, | ||
| ExpectStatus: http.StatusOK, | ||
| }), | ||
| table.Entry("create plugin config", base.HttpTestCase{ |
There was a problem hiding this comment.
It seems create plugin config => get plugin config.
| }), | ||
| table.Entry("create plugin config", base.HttpTestCase{ | ||
| Object: base.ManagerApiExpect(), | ||
| Path: "/apisix/admin/plugin_configs/1", |
|
E2E test failed |
tokers
reviewed
Mar 3, 2021
| @@ -302,6 +333,14 @@ func TestLabel(t *testing.T) { | |||
| Headers: map[string]string{"Authorization": token}, | |||
| ExpectStatus: http.StatusOK, | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
Can plugin_config be updated? If so, we should also add update test suites.
starsz
approved these changes
Mar 3, 2021
tokers
approved these changes
Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request
support plugin config in Manager API
related pr in APISIX apache/apisix#3567