Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for password grant in keycloak plugin and in dashboard #2376

Closed
wants to merge 4 commits into from
Closed

feat: add support for password grant in keycloak plugin and in dashboard #2376

wants to merge 4 commits into from

Conversation

azilentech
Copy link

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?
This PR is in the context of PR of API SIX, apache/apisix#6586

Support of password grant type for token generation in keycloak plugin.

  • Bugfix
  • [ X] New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Please update this section with a detailed description.

Related issues

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@azilentech azilentech changed the title feat: add support for password grant in keycloak plugin - corresponding changes in dashboard feat: add support for password grant in keycloak plugin and in dashboard Mar 11, 2022
* feat : add password grant token generation uri property (#2374)

Adding new property of password grant token generation incoming uri.
Support feat: #6586
@azilentech azilentech marked this pull request as draft March 21, 2022 16:12
@codecov-commenter
Copy link

Codecov Report

Merging #2376 (bf9b3a8) into master (561ed37) will decrease coverage by 19.90%.
The diff coverage is 27.88%.

❗ Current head bf9b3a8 differs from pull request most recent head e763063. Consider uploading reports for the commit e763063 to get more accurate results

@@             Coverage Diff             @@
##           master    #2376       +/-   ##
===========================================
- Coverage   68.52%   48.62%   -19.91%     
===========================================
  Files         131       42       -89     
  Lines        3419     3270      -149     
  Branches      826        0      -826     
===========================================
- Hits         2343     1590      -753     
- Misses       1076     1476      +400     
- Partials        0      204      +204     
Flag Coverage Δ
backend-unit-test 48.62% <27.88%> (?)
frontend-e2e-test ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/core/entity/entity.go 0.00% <ø> (ø)
api/internal/core/store/storehub.go 0.00% <0.00%> (ø)
api/internal/filter/cors.go 0.00% <0.00%> (ø)
api/internal/handler/data_loader/route_export.go 70.74% <0.00%> (ø)
api/internal/handler/data_loader/route_import.go 26.68% <0.00%> (ø)
api/internal/utils/utils.go 49.07% <0.00%> (ø)
...pi/internal/handler/system_config/system_config.go 58.00% <58.00%> (ø)
web/src/pages/Consumer/Create.tsx
web/src/pages/Consumer/List.tsx
web/src/pages/Consumer/components/Step1.tsx
... and 169 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 561ed37...e763063. Read the comment docs.

Rushabh-Sukhadia and others added 3 commits March 22, 2022 15:08
…ty in to dataset

change and adding password grant token generation incoming uri property in to dataset.

feat: add support for password grant in keycloak plugin configuration # 2374
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants