Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: keycloak password grant token generation uri property #2390

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Rushabh-Sukhadia
Copy link

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Keycloak plugin settings about "password grant type for token generation" are incorporated which are already merged in API SIX implementation.

Please refer:

apache/apisix/issues/6574

apache/apisix/pull/6586

Adding password grant token generation uri property.
@Rushabh-Sukhadia Rushabh-Sukhadia changed the title feat: keycloak password grant token generation uri property #2374 feat: keycloak password grant token generation uri property Mar 23, 2022
@Baoyuantop
Copy link
Contributor

Hi @Rushabh-Sukhadia, the schema.json file is automatically generated by the Control API, we prefer not to make manual changes.
Also you can refer to https://apisix.apache.org/docs/dashboard/FAQ#4-after-modifying-the-plugin-schema-or-creating-a-custom-plugin-in-apache-apisix-why-cant-i-find-it-on-the-dashboard

Reverting changes from Schema.json file as suggested
@Rushabh-Sukhadia
Copy link
Author

@Baoyuantop

I understood, reverted manual changes from schema.json file. Please review.

@Baoyuantop
Copy link
Contributor

Hi @Rushabh-Sukhadia, the schema.json file is automatically generated by the Control API, we prefer not to make manual changes. Also you can refer to https://apisix.apache.org/docs/dashboard/FAQ#4-after-modifying-the-plugin-schema-or-creating-a-custom-plugin-in-apache-apisix-why-cant-i-find-it-on-the-dashboard

We may need to replace the schema.json in this way. cc @bzp2010

@Rushabh-Sukhadia
Copy link
Author

Hi,
@Baoyuantop
@bzp2010

kindly review this PR or guide us a little if any changes needed there.

@Baoyuantop
Copy link
Contributor

Hi @Rushabh-Sukhadia, the schema.json file is automatically generated by the Control API, we prefer not to make manual changes. Also you can refer to https://apisix.apache.org/docs/dashboard/FAQ#4-after-modifying-the-plugin-schema-or-creating-a-custom-plugin-in-apache-apisix-why-cant-i-find-it-on-the-dashboard

We may need to replace the schema.json in this way. cc @bzp2010

Use this method to get the schema.json file and replace the file in the conf directory

@Rushabh-Sukhadia
Copy link
Author

Hi @Rushabh-Sukhadia, the schema.json file is automatically generated by the Control API, we prefer not to make manual changes. Also you can refer to https://apisix.apache.org/docs/dashboard/FAQ#4-after-modifying-the-plugin-schema-or-creating-a-custom-plugin-in-apache-apisix-why-cant-i-find-it-on-the-dashboard

We may need to replace the schema.json in this way. cc @bzp2010

Use this method to get the schema.json file and replace the file in the conf directory

image

Hi @Baoyuantop, I have generated schema.json file from [Control API] as you have suggested, but now after compare my generated file with the current file on git, we are finding so many different between both files. We have check and found that new downloaded file is working perfectly.
So, please find attached zip file for my new generated schema.json file and do merge if you find it correct.

schema_file.zip

@Baoyuantop
Copy link
Contributor

Hi @Rushabh-Sukhadia, sorry that we need to wait for APISIX's next container apache/apisix#6586 to be released. We need to make sure that the Dashboard matches the APISIX version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants