fix: check whether it is nil before using a variable as a object #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nic-chen
requested review from
ShiningRush,
gxthrj,
juzhiyuan,
membphis and
moonming
moonming
approved these changes
Oct 22, 2020
nic-chen
changed the title
nic-chen
changed the title
juzhiyuan
approved these changes
Oct 22, 2020
LiteSun
added a commit
to LiteSun/incubator-apisix-dashboard
that referenced
this pull request
Oct 26, 2020
* fix: lose focus when input in route step1 (apache#582) * feat: improve codes style & bug fix (apache#579) * feat: use svg locally * feat(Route): use id as rowkey * feat: update global request * feat: update import order * feat: remove unused rules * fix(Route): PluginOrchestration * feat(request): using code instead of status code * feat: remove comments * feat(i18n): consumer * feat(SSL): hide SSL currently * feat(Login): using errorHandler * feat: update version * feat: update version * feat: update plugin's version Co-authored-by: litesun <7sunmiao@gmail.com> * feat(CI): create NewCI for embedding static files into Go binaries (apache#583) Co-authored-by: bzp2010 <baizp@iydhp.com> * fix: add custom checking for resource's conf (apache#584) * fix: add custom checking for resource's conf * fix: add custom checking for resource's conf * test: add test cases * test: add test case * test: add test cases via handler * fix: remove debug log * fix: check whether it is nil before using the variable (apache#589) * chore: deployment update and remove all files related to MySQL (apache#581) * update build/run and README * feat: update dockerfile and compose * chore: update README * fix: CI failed * chore: change go version * fix doc style * fix run error * fix: update README about ETCD * fix: list item desc not showing (apache#591) * feat: docs improvment (apache#592) * feat: update action's name * feat: update action's name * feat: remove unused files * feat: update template's typo * feat: update PR template * feat: prettier lint * feat(docs): added USER_GUIDE in Chinese * feat(docs): update user guide * feat(docs): added some features * feat: added changelog in Chinese * feat(docs): added License * feat(docs): update README * feat(docs): update typo * feat(docs): remove tip * feat(docs): adjust files folder * feat(docs): adjust files folder * feat(docs): remove extra space * feat: update action's name * feat(doc): update some incompatible cases * feat(docs): added sh flag * Update deploy.zh-CN.md * feat(SSL): added SSL (apache#596) * feat(SSL): added SSL * feat: added sni search * feat: update i18n * feat: add file server (apache#594) * feat: add file server * dock: add descrition for file server * doc: update docs about preinstall in deployment (apache#597) * fix: update docs about preinstall in deployment * fix: use the exists schema.json so we don't need Lua on building Co-authored-by: 琚致远 <juzhiyuan@apache.org> * feat: added frontend login test e2e Co-authored-by: 琚致远 <juzhiyuan@apache.org> Co-authored-by: bzp2010 <bzp20000818@gmail.com> Co-authored-by: bzp2010 <baizp@iydhp.com> Co-authored-by: nic-chen <33000667+nic-chen@users.noreply.github.com> Co-authored-by: Vinci Xu <277040271@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request
Bugfix
fix: check whether it is nil before using a variable as an object, otherwise it will cause a 500 error.