Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor online debug fe #978

Merged
merged 16 commits into from
Dec 19, 2020
Merged

Refactor online debug fe #978

merged 16 commits into from
Dec 19, 2020

Conversation

liuxiran
Copy link
Contributor

@liuxiran liuxiran commented Dec 7, 2020 •
edited
Loading

Please answer these questions before submitting a pull request

@codecov-io
Copy link

codecov-io commented Dec 7, 2020 •
edited
Loading

Codecov Report

Merging #978 (afc17b4) into master (fc05b7d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #978   +/-   ##
=======================================
  Coverage   40.50%   40.50%           
=======================================
  Files          27       27           
  Lines        1627     1627           
=======================================
  Hits          659      659           
  Misses        873      873           
  Partials       95       95

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc05b7d...afc17b4. Read the comment docs.

juzhiyuan
juzhiyuan reviewed Dec 11, 2020
View reviewed changes
Copy link
Member

@juzhiyuan juzhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except some React tips.

web/src/pages/Route/components/DebugViews/AuthenticationView.tsx Outdated Show resolved Hide resolved
web/src/pages/Route/components/DebugViews/AuthenticationView.tsx Outdated Show resolved Hide resolved
web/src/pages/Route/components/DebugViews/DebugDrawView.tsx Outdated Show resolved Hide resolved
web/src/pages/Route/components/DebugViews/DebugParamsView.tsx Outdated Show resolved Hide resolved
web/src/pages/Route/service.ts Outdated Show resolved Hide resolved
juzhiyuan
juzhiyuan approved these changes Dec 11, 2020
View reviewed changes
Copy link
Member

@juzhiyuan juzhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for #979

@liuxiran
Copy link
Contributor Author

#1026
this issue was recured in current branch, tring to resolve~

@liuxiran
Copy link
Contributor Author

#1026
this issue was recured in current branch, tring to resolve~

I re-import the new dependency packages and updated yarn.lock, this issue solved, but as a bad effect, I have to rebase the master branch, and use force-pushed to update pr, which disturbed code review, sorry for all reviewers.

@liuxiran
Copy link
Contributor Author

tring to yarn install Cypress frist to solve the yarn.lock conflict.

@liuxiran
Copy link
Contributor Author

IMHO this pr is ready, it can be merged after #979 ^_^

@juzhiyuan juzhiyuan merged commit c6f730b into apache:master Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juzhiyuan juzhiyuan juzhiyuan approved these changes

@LiteSun LiteSun LiteSun approved these changes

@membphis membphis Awaiting requested review from membphis

Assignees
No one assigned
Labels
pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liuxiran @codecov-io @juzhiyuan @LiteSun