fix: revert Topology Spread Constraints to apisix #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ikatlinsky. Sorry to interrupt you. Please, could you review this little PR and the other also. Thank you |
hi! i think helm docs was not updated, which is the cause of failing build. There is a make file in the repo with job helm-docs to do that. |
Ok, I just added it |
|
@AlinsRan, @Gallardot can you please take a look at this PR, thanks |
Gallardot
approved these changes
Jun 6, 2024
AlinsRan
approved these changes
Jun 7, 2024
AlinsRan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add topologySpreadContrainsts option for apisix deployment
It was introduced here, but it was removed