Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Control Ingress Creation #783

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

alfredopalhares
Copy link

By default if you enable ingress for the control api the chart breaks, its checking bad place for the servicePort.

This fixes that, and add tests with helm- unittest, it currently only tests this exact situation, since i dont know if its something that the maintainers want. I can add more unitttest if you want.

Regards,
Alfredo Palhares

@kzmain
Copy link

kzmain commented Feb 21, 2025

Hi alfredopalhares, may I ask does our control api work well after you updated the code? I did the same fix as yours, and it shows 404 error per screenshot shows.
The helm command that I start the servies is:

helm repo add apisix https://charts.apiseven.com
helm repo update
helm upgrade --install apisix . \
--create-namespace --namespace apisix \
--set ingress.enabled=true \
--set ingress.className=nginx \
--set "ingress.hosts[0].host=apisix\.local" \
--set "ingress.hosts[0].paths[0]=\/" \
--set apisix.admin.enabled=true \
--set apisix.admin.ingress.enabled=true \
--set apisix.admin.ingress.className=nginx \
--set control.enabled=true \
--set control.ingress.enabled=true \
--set control.ingress.className=nginx \
--set ingress-controller.enabled=true \
--set ingress-controller.config.apisix.serviceNamespace=apisix

Screenshot 2025-02-22 at 03 09 56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants