Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow nodePort & servicePort also to be configured in additionalContainerPorts #787

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow nodePort & servicePort also to be configured in additionalContainerPorts #787

wants to merge 2 commits into from

Conversation

pavankumar-go
Copy link

@pavankumar-go pavankumar-go commented Nov 4, 2024 •
edited
Loading

currently for configuring gateway service only the port parameter is used to populate TargetPort and ServicePort. which is quite limiting in certain conditions

    additionalContainerPorts:
      - port: 9081

With added changes:

    additionalContainerPorts:
      - port: 8443
        servicePort: 80    # optional, if not set uses `.port` value, hence it does not cause breaking changes
        nodePort: 30303 # optional

@luismiguelsaez-steercrm
Copy link

luismiguelsaez-steercrm commented Nov 29, 2024 •
edited
Loading

Seems similar to the one I opened some time ago: #782, although mine is aimed at modifying the service's SSL port to accommodate to use-cases where an AWS NLB is created from load balancer controller.

Anyway, it looks like no one is taking any of them into account :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavankumar-go @luismiguelsaez-steercrm