Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: tcproute/httproute is missing old objects, resulting in a crash #1826

Closed
AlinsRan opened this issue May 5, 2023 · 0 comments · Fixed by #1825
Closed

bug: tcproute/httproute is missing old objects, resulting in a crash #1826

AlinsRan opened this issue May 5, 2023 · 0 comments · Fixed by #1825
Assignees
Labels
bug Something isn't working triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone

Comments

@AlinsRan
Copy link
Contributor

AlinsRan commented May 5, 2023

  1. When triggering an update in the HTTPRoute, no OldObject was passed .

c.workqueue.Add(&types.Event{
Type: types.EventUpdate,
Object: key,
})

  1. During synchronization, type assertion will fail.

oldObj := ev.OldObject.(*gatewayv1beta1.HTTPRoute)

TCPRoute also has this issue

c.workqueue.Add(&types.Event{
Type: types.EventUpdate,
Object: key,
})

@AlinsRan AlinsRan changed the title bug: gateway_xxx is missing old objects, resulting in a crash bug: tcproute/httproute is missing old objects, resulting in a crash May 5, 2023
@AlinsRan AlinsRan added bug Something isn't working triage/accepted Indicates an issue or PR is ready to be actively worked on. labels May 5, 2023
@AlinsRan AlinsRan self-assigned this May 5, 2023
@tao12345666333 tao12345666333 added this to the v1.7.0 milestone May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
2 participants