Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Referencing empty objects during tcproute and httproute updates #1825

Merged
merged 2 commits into from
May 5, 2023

Conversation

AlinsRan
Copy link
Contributor

@AlinsRan AlinsRan commented May 4, 2023

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches
  • Documentation
  • Refactor
  • Chore
  • CI/CD or Tests

What this PR does / why we need it:

close: #1826

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

codecov-commenter commented May 4, 2023

Codecov Report

Merging #1825 (b236399) into master (98ff8e5) will increase coverage by 0.14%.
The diff coverage is 0.00%.

❗ Current head b236399 differs from pull request most recent head e2f68b3. Consider uploading reports for the commit e2f68b3 to get more accurate results

@@            Coverage Diff             @@
##           master    #1825      +/-   ##
==========================================
+ Coverage   39.30%   39.45%   +0.14%     
==========================================
  Files          91       91              
  Lines        8073     8043      -30     
==========================================
  Hits         3173     3173              
+ Misses       4494     4463      -31     
- Partials      406      407       +1     
Impacted Files Coverage Δ
pkg/apisix/cluster.go 28.37% <0.00%> (+0.23%) ⬆️
...kg/providers/apisix/translation/apisix_consumer.go 65.21% <0.00%> (-1.95%) ⬇️
pkg/providers/ingress/ingress.go 4.98% <0.00%> (+0.44%) ⬆️
pkg/providers/ingress/translation/translator.go 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlinsRan AlinsRan marked this pull request as ready for review May 4, 2023 09:55
@AlinsRan AlinsRan marked this pull request as draft May 4, 2023 09:55
@AlinsRan AlinsRan marked this pull request as ready for review May 5, 2023 01:11
@tao12345666333 tao12345666333 merged commit 31891ba into apache:master May 5, 2023
@tao12345666333 tao12345666333 added bug Something isn't working area/controller labels May 5, 2023
@tao12345666333 tao12345666333 added this to the v1.7.0 milestone May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controller bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: tcproute/httproute is missing old objects, resulting in a crash
4 participants