Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ScopeQuery should be case sensitive (#1168) #1188

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

suninuni
Copy link
Contributor

@suninuni suninuni commented Jul 26, 2022

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

#1168

arg_xxx in APISIX is case sensitive, so ScopeQuery don't need being translated to lower case.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@suninuni
Copy link
Contributor Author

@tao12345666333

Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tao12345666333 tao12345666333 added this to the 1.5.0 milestone Jul 26, 2022
@tao12345666333 tao12345666333 added bug Something isn't working area/controller labels Jul 26, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1188 (101fe58) into master (a0bc739) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1188   +/-   ##
=======================================
  Coverage   29.98%   29.98%           
=======================================
  Files          81       81           
  Lines        9979     9979           
=======================================
  Hits         2992     2992           
  Misses       6663     6663           
  Partials      324      324           
Impacted Files Coverage Δ
pkg/kube/translation/apisix_route.go 20.60% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

@tao12345666333 tao12345666333 merged commit 5f45b63 into apache:master Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controller bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

request help: http[].match.exprs[].subject.name shoule be case sensetive
6 participants