Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support gateway/tcproute #1217

Merged
merged 21 commits into from
Sep 26, 2022
Merged

Conversation

AlinsRan
Copy link
Contributor

@AlinsRan AlinsRan commented Aug 4, 2022

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@tao12345666333 tao12345666333 added area/controller enhancement New feature or request labels Aug 5, 2022
@tao12345666333
Copy link
Member

please resolve conflics. thanks!

@tao12345666333
Copy link
Member

please resolve conflics again. thanks

@tao12345666333 tao12345666333 self-assigned this Aug 17, 2022
@tao12345666333 tao12345666333 added this to the v1.6.0 milestone Aug 17, 2022
@tao12345666333 tao12345666333 self-requested a review August 17, 2022 09:55
@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2022

Codecov Report

Merging #1217 (a53dfff) into master (f71b376) will increase coverage by 0.11%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master    #1217      +/-   ##
==========================================
+ Coverage   40.62%   40.73%   +0.11%     
==========================================
  Files          75       77       +2     
  Lines        7006     7030      +24     
==========================================
+ Hits         2846     2864      +18     
- Misses       3847     3851       +4     
- Partials      313      315       +2     
Impacted Files Coverage Δ
pkg/providers/gateway/translation/gateway.go 0.00% <ø> (ø)
...providers/gateway/translation/gateway_httproute.go 64.10% <ø> (ø)
.../providers/gateway/translation/gateway_tlsroute.go 0.00% <ø> (ø)
pkg/providers/gateway/translation/translator.go 0.00% <ø> (ø)
pkg/providers/utils/generic.go 0.00% <0.00%> (ø)
.../providers/gateway/translation/gateway_tcproute.go 81.81% <81.81%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lingsamuel lingsamuel self-requested a review August 23, 2022 08:07
@tao12345666333 tao12345666333 changed the title feat: support gateway/tcproute feat: support gateway/tcproute round 1 Aug 29, 2022
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you write about your plans for TCPRoute support in the description of this PR?
I see that the Add event is mostly handled in this PR, but the Update and Delete events etc. are not handled.

I added the round 1 flag to the title

@AlinsRan
Copy link
Contributor Author

Can you write about your plans for TCPRoute support in the description of this PR? I see that the Add event is mostly handled in this PR, but the Update and Delete events etc. are not handled.

I added the round 1 flag to the title

Preliminary support update and delete has been given.

@tao12345666333
Copy link
Member

@AlinsRan could you please merge latest code?

@AlinsRan AlinsRan changed the title feat: support gateway/tcproute round 1 feat: support gateway/tcproute Sep 13, 2022
@AlinsRan AlinsRan requested review from tao12345666333 and lingsamuel and removed request for tao12345666333 and lingsamuel September 13, 2022 06:38
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tao12345666333 tao12345666333 merged commit 3877ee8 into apache:master Sep 26, 2022
@tao12345666333 tao12345666333 mentioned this pull request Sep 26, 2022
14 tasks
@AlinsRan AlinsRan deleted the gateway/tcproute branch October 31, 2022 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controller enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

4 participants