-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support gateway/tcproute #1217
Conversation
please resolve conflics. thanks! |
please resolve conflics again. thanks |
Codecov Report
@@ Coverage Diff @@
## master #1217 +/- ##
==========================================
+ Coverage 40.62% 40.73% +0.11%
==========================================
Files 75 77 +2
Lines 7006 7030 +24
==========================================
+ Hits 2846 2864 +18
- Misses 3847 3851 +4
- Partials 313 315 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you write about your plans for TCPRoute support in the description of this PR?
I see that the Add event is mostly handled in this PR, but the Update and Delete events etc. are not handled.
I added the round 1
flag to the title
Preliminary support update and delete has been given. |
@AlinsRan could you please merge latest code? |
365e289
to
819068c
Compare
819068c
to
a53dfff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Type of change:
What this PR does / why we need it:
Pre-submission checklist: