-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update develop.md #129
Conversation
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
==========================================
+ Coverage 61.22% 61.79% +0.56%
==========================================
Files 16 16
Lines 539 547 +8
==========================================
+ Hits 330 338 +8
Misses 185 185
Partials 24 24
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the license of postmanlabs/httpbin
is ISC, which is live in harmony with Apache license.
@@ -89,12 +93,14 @@ spec: | |||
http: | |||
paths: | |||
- backend: | |||
serviceName: httpserver | |||
serviceName: httpbin.default.svc.cluster.local |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found the port of httpbin container is 80, the port should be change to 80
instead of 8080
.
Or we do need a service
file to describe the port Mapping.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, let me add the service/deployment description in doc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed @gxthrj .
@@ -115,7 +121,7 @@ spec: | |||
http: | |||
paths: | |||
- backend: | |||
serviceName: httpserver | |||
serviceName: httpbin.default.svc.cluster.local | |||
servicePort: 8080 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
@@ -165,7 +171,7 @@ kubectl apply -f - <<EOF | |||
apiVersion: apisix.apache.org/v1 | |||
kind: ApisixUpstream # apisix upstream | |||
metadata: | |||
name: httpserver # default/httpserver | |||
name: httpbin # default/httpbin | |||
spec: | |||
ports: | |||
- port: 8080 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
@membphis Please take a look when you have time. |
Fixing #30.