-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support kubebuilder #1320
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1320 +/- ##
==========================================
- Coverage 42.65% 39.73% -2.92%
==========================================
Files 73 75 +2
Lines 6478 6979 +501
==========================================
+ Hits 2763 2773 +10
- Misses 3418 3907 +489
- Partials 297 299 +2 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
b40976b
to
29d15d0
Compare
/hold |
@@ -42,3 +42,5 @@ apisix-ingress-controller | |||
.actions/openwhisk-utilities | |||
|
|||
.generated | |||
|
|||
bin/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing EOF
We can update the gitattribute file after this PR merge. |
pluginMap[plugin.Name] = plugin.Config | ||
if plugin.Config.Size() > 0 { | ||
config := map[string]interface{}{} | ||
_ = json.Unmarshal(plugin.Config.Raw, &config) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the error is ignored?
@@ -24,7 +24,7 @@ import ( | |||
) | |||
|
|||
// GroupName specifies the group name used to register the objects. | |||
const GroupName = "apisix.apache.org" | |||
const GroupName = "config" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is wrong. Leave the group option empty to let it use the domain (apisix.apache.org) directly.
Since there will be a lot of changes involved here, and there will be a lot of conflicts, I want to put it in the v1.7 version. |
This is a huge PR, but we don't have much time to continue reviewing it. Let me move it to v1.8 and hopefully we can complete it in the next release. |
Removing this from v1.8 milestone |
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 30 days if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions. |
This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
Type of change:
What this PR does / why we need it:
use:
Pre-submission checklist: