Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support kubebuilder #1320

Closed
wants to merge 5 commits into from
Closed

Conversation

AlinsRan
Copy link
Contributor

@AlinsRan AlinsRan commented Sep 6, 2022

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

  • Can use kuberbuider to automatically update CRD resources.
  • No longer need to maintain CRD resources.
    • Prone to errors and omissions.

use:

  • make manifests

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2022

Codecov Report

Merging #1320 (29d15d0) into master (6b86d2a) will decrease coverage by 2.91%.
The diff coverage is 22.22%.

@@            Coverage Diff             @@
##           master    #1320      +/-   ##
==========================================
- Coverage   42.65%   39.73%   -2.92%     
==========================================
  Files          73       75       +2     
  Lines        6478     6979     +501     
==========================================
+ Hits         2763     2773      +10     
- Misses       3418     3907     +489     
- Partials      297      299       +2     
Impacted Files Coverage Δ
pkg/providers/apisix/translation/apisix_route.go 19.10% <17.39%> (-0.04%) ⬇️
...viders/apisix/translation/apisix_cluster_config.go 50.00% <50.00%> (ø)
...roviders/apisix/translation/apisix_pluginconfig.go 36.66% <50.00%> (ø)
pkg/providers/ingress/ingress.go 5.14% <0.00%> (-0.08%) ⬇️
.../providers/ingress/translation/annotations/cors.go
...oviders/ingress/translation/annotations/rewrite.go
.../providers/ingress/translation/annotations/csrf.go
...providers/ingress/translation/annotations/types.go
...s/ingress/translation/annotations/iprestriction.go
...s/ingress/translation/annotations/authorization.go
... and 12 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlinsRan AlinsRan marked this pull request as ready for review September 7, 2022 06:44
@tao12345666333 tao12345666333 added this to the v1.6.0 milestone Sep 7, 2022
@lingsamuel
Copy link
Member

/hold
#515 (comment) Careful verification is required that the CRD checking rules have been properly ported to the code base.
Also, old CRD files should be deleted.

@@ -42,3 +42,5 @@ apisix-ingress-controller
.actions/openwhisk-utilities

.generated

bin/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing EOF

@lingsamuel
Copy link
Member

We can update the gitattribute file after this PR merge.

pluginMap[plugin.Name] = plugin.Config
if plugin.Config.Size() > 0 {
config := map[string]interface{}{}
_ = json.Unmarshal(plugin.Config.Raw, &config)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the error is ignored?

@@ -24,7 +24,7 @@ import (
)

// GroupName specifies the group name used to register the objects.
const GroupName = "apisix.apache.org"
const GroupName = "config"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is wrong. Leave the group option empty to let it use the domain (apisix.apache.org) directly.

@AlinsRan AlinsRan marked this pull request as draft September 16, 2022 09:54
@tao12345666333
Copy link
Member

Since there will be a lot of changes involved here, and there will be a lot of conflicts, I want to put it in the v1.7 version.

@tao12345666333 tao12345666333 modified the milestones: v1.6.0, v1.7.0 Dec 12, 2022
@tao12345666333
Copy link
Member

This is a huge PR, but we don't have much time to continue reviewing it. Let me move it to v1.8 and hopefully we can complete it in the next release.

@tao12345666333 tao12345666333 modified the milestones: v1.7.0, 1.8.0 Aug 31, 2023
@Revolyssup Revolyssup removed this from the 1.8.0 milestone Nov 21, 2023
@Revolyssup
Copy link
Contributor

Removing this from v1.8 milestone

Copy link

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 30 days if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 21, 2024
Copy link

This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Use controller-gen to generate CRDs instead of writing them by hand
5 participants