Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support k8s native ingress and backend service in different… #1377

Merged
merged 4 commits into from
Nov 1, 2022

Conversation

shareinto
Copy link
Contributor

@shareinto shareinto commented Oct 10, 2022

… namespace

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

Resolves #1374

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

Codecov Report

Merging #1377 (87ae998) into master (40f1372) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

❗ Current head 87ae998 differs from pull request most recent head 8892ad2. Consider uploading reports for the commit 8892ad2 to get more accurate results

@@            Coverage Diff             @@
##           master    #1377      +/-   ##
==========================================
- Coverage   40.73%   40.68%   -0.06%     
==========================================
  Files          77       77              
  Lines        7030     7039       +9     
==========================================
  Hits         2864     2864              
- Misses       3851     3860       +9     
  Partials      315      315              
Impacted Files Coverage Δ
pkg/providers/ingress/translation/annotations.go 58.82% <ø> (ø)
pkg/providers/ingress/translation/translator.go 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tao12345666333
Copy link
Member

Thanks! Let me take a look.

@tao12345666333 tao12345666333 self-assigned this Oct 10, 2022
@shareinto
Copy link
Contributor Author

shareinto commented Oct 11, 2022

@tao12345666333 e2e test has passed in my local environment,how can i rerun this,would you help please

@shareinto shareinto changed the title feat: support k8s native ingress and backend service in the different… feat: support k8s native ingress and backend service in different… Oct 12, 2022
Copy link
Member

@lingsamuel lingsamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review, code LGTM, but PR needs to resolve the conflict. Thanks!

@lingsamuel
Copy link
Member

@tao12345666333 PTAL

@tao12345666333 tao12345666333 added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Oct 27, 2022
@tao12345666333 tao12345666333 added this to the v1.6.0 milestone Oct 27, 2022
@tao12345666333
Copy link
Member

yes! code LGTM.

Please resolve conflicts. Thanks!

@shareinto shareinto requested review from lingsamuel and removed request for tao12345666333, tokers and AlinsRan October 27, 2022 16:01
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tao12345666333 tao12345666333 merged commit 6879c81 into apache:master Nov 1, 2022
@shareinto shareinto deleted the feat/svcNamespace branch November 1, 2022 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Development

Successfully merging this pull request may close these issues.

feat: support k8s native ingress and backend service in the different namespace
4 participants