Feat (dev env): allow to custom registry port for make kind-up
#1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zou8944
changed the title
make kind-upmake kind-up
tao12345666333
changed the title
make kind-upmake kind-up
tao12345666333
approved these changes
Nov 1, 2022
lingsamuel
reviewed
Nov 3, 2022
zou8944
commented
Nov 3, 2022
| @@ -67,7 +67,7 @@ nodes: | |||
| containerdConfigPatches: | |||
| - |- | |||
| [plugins."io.containerd.grpc.v1.cri".registry.mirrors."localhost:${reg_port}"] | |||
| endpoint = ["http://${reg_host}:${reg_port}"] | |||
| endpoint = ["http://${reg_host}:5000"] | |||
There was a problem hiding this comment.
Hi, @tao12345666333 @lingsamuel , I update this port, it should be fixed 5000 port.
There was a problem hiding this comment.
Hi, @tao12345666333 @lingsamuel , I update this port, it should be fixed 5000 port.
why it should be 5000?
There was a problem hiding this comment.
@tao12345666333 the endpoint will be visit by k8s node which kind created, so the port should be the one that registry exposed (which is 5000 fixed), not the one that registry published on our local machine.
you can also refer to the kind doc, and pay attention to this part
|
@tao12345666333 @lingsamuel , New commit updated, please review, thanks. |
tao12345666333
approved these changes
Nov 10, 2022
lingsamuel
approved these changes
Nov 15, 2022
lingsamuel
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change:
What this PR does / why we need it:
#1416
Pre-submission checklist: