Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update ApisixRoute/v2 reference #1423

Merged

Conversation

pottekkat
Copy link
Member

Signed-off-by: Navendu Pottekkat navendu@apache.org

Updates the documentation of ApisixRoute/v2 reference page.

Similar changes would be made across the reference section after approving this PR.

Signed-off-by: Navendu Pottekkat <navendu@apache.org>
Signed-off-by: Navendu Pottekkat <navendu@apache.org>
@pottekkat
Copy link
Member Author

Any idea why there is this lint error? https://github.com/apache/apisix-ingress-controller/actions/runs/3367934841/jobs/5585981373#step:5:6

It is not obvious what the issue is to me.

@juzhiyuan
Copy link
Member

image

Error from other docs, I think we can ignore them in this PR.

Copy link
Member

@juzhiyuan juzhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other content LGTM

| http[].name | string (required) | Route rule name. |
| http[].priority | integer | Route priority. Used to determined which Route to use when multiple routes contain the same URI. Large number means higher priority. |
| http[].timeout | object | Timeouts for connecting, sending, and receiving messages between Ingress and the service. This will overwrite the value configured in `ApisixUpstream` resource. |
| http[].timeout.connect | string | Connect timeout in the form "72h3m0.5s". |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @navendu-pottekkat, is this expected?

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juzhiyuan I did not understand your question.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

This form is valid?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know. I did not change it. @tao12345666333 could you confirm?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me check it.

Copy link
Member

@juzhiyuan juzhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other LGTM

Signed-off-by: Navendu Pottekkat <navendu@apache.org>
This reverts commit 9818e4f.
Copy link
Member

@juzhiyuan juzhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other LGTM

docs/en/latest/references/apisix_route_v2.md Outdated Show resolved Hide resolved
Co-authored-by: 琚致远 / Zhiyuan Ju <juzhiyuan@apache.org>
Signed-off-by: Navendu Pottekkat <navendu@apache.org>
@pottekkat
Copy link
Member Author

I have fixed the link check error in a different PR. All checks will pass here.

Signed-off-by: Navendu Pottekkat <navendu@apache.org>
@pottekkat
Copy link
Member Author

@juzhiyuan @tao12345666333 I have updated the v2beta3 docs as well in this PR. Please review and merge.

@tao12345666333 tao12345666333 merged commit 47906a5 into apache:master Nov 16, 2022
@pottekkat pottekkat deleted the docs/reference/ApisixRoutev2/1 branch November 16, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants