feat: support HTTPRequestMirrorFilter in HTTPRoute #1461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
Codecov Report
@@ Coverage Diff @@
## master #1461 +/- ##
==========================================
- Coverage 41.35% 41.26% -0.10%
==========================================
Files 82 82
Lines 7261 7277 +16
==========================================
Hits 3003 3003
- Misses 3911 3927 +16
Partials 347 347
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tao12345666333
requested changes
Nov 17, 2022
| ns = string(*reqMirror.BackendRef.Namespace) | ||
| } | ||
| // To do: Need to support https | ||
| host := fmt.Sprintf("http://%s.%s.svc.cluster.local:%d", reqMirror.BackendRef.Name, ns, port) |
There was a problem hiding this comment.
The cluster domain can be changed.
We can just use foo.bar.svc instead
lingsamuel
approved these changes
Nov 17, 2022
tao12345666333
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change:
What this PR does / why we need it:
Pre-submission checklist: