-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: unified factory and informer #1530
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1530 +/- ##
==========================================
+ Coverage 41.22% 41.41% +0.18%
==========================================
Files 85 85
Lines 7440 7406 -34
==========================================
Hits 3067 3067
+ Misses 4020 3986 -34
Partials 353 353
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Co-authored-by: Jintao Zhang <tao12345666333@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I communicated offline with @AlinsRan who has been testing this PR for a long time. So I think it's safe to merge it now |
I think we should add some performance testing, and get related metrics and reports. |
Type of change:
What this PR does / why we need it:
fix:
With the increase of functional requirements, the interdependence between resources is inevitable. We should unify the informer structure to avoid errors caused by resources not being ready.
Pre-submission checklist: