fix: allow passing plugin config name for route with no backends

[ikatlinsky]

Type of change:

• Bugfix
• New feature provided
• Improve performance
• Backport patches

What this PR does / why we need it:

This PR fixes the issue of ignoring passed PluginConfigName in case ApisixRoute definition contains only upstreams and not backends configuration.

The issue is described here in detail - #1577.

Pre-submission checklist:

• Did you explain what problem does this PR solve? Or what new features have been added?
• Have you added corresponding test cases?
• Have you modified the corresponding document?
• Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

[codecov-commenter]

Codecov Report

Merging #1578 (a6668b5) into master (486b46a) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1578      +/-   ##
==========================================
+ Coverage   41.44%   41.52%   +0.08%     
==========================================
  Files          87       87              
  Lines        7420     7420              
==========================================
+ Hits         3075     3081       +6     
+ Misses       3990     3986       -4     
+ Partials      355      353       -2     

Impacted Files	Coverage Δ
pkg/providers/apisix/translation/apisix_route.go	31.21% <100.00%> (+0.81%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[AlinsRan]

Please add relevant e2e test cases

[tao12345666333]

As @AlinsRan said, you can use the use case you described in #1577 as an e2e test case to easily verify that this function works as expected. Thanks

[tao12345666333]

When this PR is merged, I will cherry-pick it into v1.6.1

[ikatlinsky]

As @AlinsRan said, you can use the use case you described in #1577 as an e2e test case to easily verify that this function works as expected. Thanks

yep, just trying to configure the environment locally for e2e tests, have a couple of issues to solve with existing tests, like following one

Begin Captured StdOut/StdErr Output >>
    2023-01-03T10:10:21+01:00   error   apisix/route.go:118     failed to list routes: Get "http://localhost:31358/apisix/admin/routes": dial tcp [::1]:31358: connect: connection refused
    2023-01-03T10:10:21+01:00   error   apisix/cluster.go:222   failed to list routes in APISIX: Get "http://localhost:31358/apisix/admin/routes": dial tcp [::1]:31358: connect: connection refused
    2023-01-03T10:10:23+01:00   error   apisix/route.go:118     failed to list routes: Get "http://localhost:31358/apisix/admin/routes": dial tcp [::1]:31358: connect: connection refused
    2023-01-03T10:10:23+01:00   error   apisix/cluster.go:222   failed to list routes in APISIX: Get "http://localhost:31358/apisix/admin/routes": dial tcp [::1]:31358: connect: connection refused
    2023-01-03T10:10:25+01:00   error   apisix/route.go:118     failed to list routes: Get "http://localhost:31358/apisix/admin/routes": dial tcp [::1]:31358: connect: connection refused
    2023-01-03T10:10:25+01:00   error   apisix/cluster.go:222   failed to list routes in APISIX: Get "http://localhost:31358/apisix/admin/routes": dial tcp [::1]:31358: connect: connection refused
    2023-01-03T10:10:25+01:00   error   apisix/cluster.go:182   failed to sync cache    {"cost_time": "8.016621029s", "cluster": ""}
  << End Captured StdOut/StdErr Output

[ikatlinsky]

@tao12345666333 added a new e2e test into suite-plugins-other, hope that this location is ok, make me know if the test should be moved to another suite.

Also, I placed my test directly under the suite-plugins-other: scaffold v2 section, as it uses API which is not available in v2beta3.

[tao12345666333]

@ikatlinsky good job! This location is fine.

[ikatlinsky]

@tao12345666333 is anything else required from my side to push forward this fix for being merged?

thanks

[tao12345666333]

LGTM