Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add svc-namespace description to the annotations #1605

Merged
merged 4 commits into from
Jan 30, 2023
Merged

doc: add svc-namespace description to the annotations #1605

merged 4 commits into from
Jan 30, 2023

Conversation

AlinsRan
Copy link
Contributor

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@tao12345666333 tao12345666333 added the documentation Improvements or additions to documentation label Jan 19, 2023
juzhiyuan
juzhiyuan approved these changes Jan 22, 2023
View reviewed changes
Copy link
Member

@juzhiyuan juzhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! This question has been asked many times

pottekkat
pottekkat reviewed Jan 22, 2023
View reviewed changes
docs/en/latest/concepts/annotations.md Outdated Show resolved Hide resolved
docs/en/latest/concepts/annotations.md Outdated Show resolved Hide resolved
docs/en/latest/concepts/annotations.md Outdated Show resolved Hide resolved
AlinsRan and others added 2 commits January 29, 2023 09:21
@AlinsRan @pottekkat
Update docs/en/latest/concepts/annotations.md
27d3340 
Co-authored-by: Navendu Pottekkat <navendupottekkat@gmail.com>
@AlinsRan
Update annotations.md
cfbdef3
@AlinsRan AlinsRan requested a review from pottekkat January 29, 2023 01:48
@tao12345666333 tao12345666333 added this to the v1.7.0 milestone Jan 29, 2023
@pottekkat pottekkat merged commit a16b3dd into apache:master Jan 30, 2023
AlinsRan added a commit to AlinsRan/apisix-ingress-controller that referenced this pull request Jan 30, 2023
@AlinsRan @pottekkat
doc: add svc-namespace description to the annotations (apache#1605)
de68f14 
Co-authored-by: Navendu Pottekkat <navendupottekkat@gmail.com>
tao12345666333 pushed a commit that referenced this pull request Jan 30, 2023
@AlinsRan @pottekkat
doc: add svc-namespace description to the annotations (#1605) (#1624)
db20b67 
Co-authored-by: Navendu Pottekkat <navendupottekkat@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pottekkat pottekkat pottekkat approved these changes

@juzhiyuan juzhiyuan juzhiyuan approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation process/cherry-pick
Projects
None yet
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@AlinsRan @juzhiyuan @pottekkat @tao12345666333