Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: upgrade CI ginkgo 1.9.0 to 1.9.2 #1800

Merged
merged 2 commits into from
Apr 19, 2023
Merged

Chore: upgrade CI ginkgo 1.9.0 to 1.9.2 #1800

merged 2 commits into from
Apr 19, 2023

Conversation

im-jinxinwang
Copy link
Contributor

@im-jinxinwang im-jinxinwang commented Apr 18, 2023

Type of change:

  • Chore

What this PR does / why we need it:

upgrade CI ginkgo 1.9.0 to 1.9.2,reference (#1799)

@im-jinxinwang im-jinxinwang changed the title Chore: upgrade CI ginkgo 1.9.0 to 1.9.2(#1799) Chore: upgrade CI ginkgo 1.9.0 to 1.9.2 Apr 18, 2023
@basefas
Copy link
Contributor

basefas commented Apr 18, 2023

also need to change in makefile,ginkgo-check

@codecov-commenter
Copy link

Codecov Report

Merging #1800 (07fad8d) into master (4b1ad1b) will not change coverage.
The diff coverage is n/a.

❗ Current head 07fad8d differs from pull request most recent head aa80765. Consider uploading reports for the commit aa80765 to get more accurate results

@@           Coverage Diff           @@
##           master    #1800   +/-   ##
=======================================
  Coverage   39.29%   39.29%           
=======================================
  Files          91       91           
  Lines        8075     8075           
=======================================
  Hits         3173     3173           
  Misses       4495     4495           
  Partials      407      407           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@Gallardot Gallardot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution.

Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tao12345666333 tao12345666333 merged commit 2061824 into apache:master Apr 19, 2023
@Qizeng-api7
Copy link

Hello @WVenus! I am the operator of the APISIX Community. Thank you for your contribution to Apache APISIX! To express our gratitude and encouragement for your contribution, the Apache APISIX community would like to present to you the APISIX Contributor Certificate! However, we couldn't find your email address on your GitHub page, would you mind letting us know? We will send you a digital certificate by email later as a token of our appreciation.

@im-jinxinwang
Copy link
Contributor Author

@Qizeng-api7 My email is: g1561925068@gmail.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants