-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for host pass in upstream crd #1889
feat: add support for host pass in upstream crd #1889
Conversation
Will need some time to investigate why e2e tests are failing, I checked them in the master branch and they are also failing quite randomly (example for external-service.go):
@tao12345666333 is it a known issue? |
no |
here is an example of the failing build on master branch today https://github.com/apache/apisix-ingress-controller/actions/runs/5491609801 |
let me take a look |
I will take some time to solve the CI problems. After all test passed, we can merge this one. |
nice, make me know when CI problems will be resolved, so i can run test on my side too |
I hate to bug you on this @tao12345666333 , but i was wondering if you had any idea when you might have time to take a look at the tests. This is the last feature we need to have purely crd based deployment and we are very excited it is already in the pipeline to deployment. Thanks for all the work so far on this |
Please merge the master branch first. All test cases be fixed. Thanks |
@tao12345666333 merged master into my branch, but at least locally, tests are randomly failing for me with a 504 gateway timeout error. That may not be the case in GitHub actions. |
@tao12345666333 as i see builds on master are still failing https://github.com/apache/apisix-ingress-controller/actions/runs/5767636410 |
yes. I will fix the test cases in #1918 |
@ikatlinsky Please merge the latest code from the master branch. We have fixed the CI issues. |
@tao12345666333 done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Type of change:
What this PR does / why we need it:
As per feature request #1661
Pre-submission checklist: