Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: re-design nginxVars to exprs #306

Merged
merged 1 commit into from
Mar 20, 2021

Conversation

tokers
Copy link
Contributor

@tokers tokers commented Mar 18, 2021

Please answer these questions before submitting a pull request

  • Why submit this pull request?

  • Bugfix

  • New feature provided

  • Improve performance

  • Backport patches

  • Related issues


Bugfix

  • Description

  • How to fix?


New feature or improvement

  • Describe the details and related test reports.

This PR renames the nginxVars field in ApisixRoute to exprs, which is more expressive, also, the subject in exprs is re-designed to be an object which contains the scope and name field.

The scope field specifies where to find the subject, it can be:

  • Header - HTTP request headers
  • Cookie - Cookie
  • Query - Query string
  • Path - URI Path

The name field specifies the subject name, which can be empty when scope is Path.


Backport patches

  • Why need to backport?

  • Source branch

  • Related commits and pull requests

  • Target branch

@tokers tokers requested a review from gxthrj March 18, 2021 08:31
@tokers tokers changed the title chore: redesign nginxVars to exprs chore: re-design nginxVars to exprs Mar 18, 2021
@tokers
Copy link
Contributor Author

tokers commented Mar 18, 2021

@membphis @gxthrj Please take a look when you have time.

@gxthrj gxthrj merged commit 6461186 into apache:master Mar 20, 2021
@tokers tokers deleted the chore/rename-nginx-vars branch March 21, 2021 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants