fix: pass remote_addrs to APISIX #347
Conversation
Codecov Report
@@ Coverage Diff @@
## master #347 +/- ##
==========================================
- Coverage 43.84% 43.40% -0.44%
==========================================
Files 40 39 -1
Lines 3435 3449 +14
==========================================
- Hits 1506 1497 -9
- Misses 1761 1781 +20
- Partials 168 171 +3
Continue to review full report at Codecov.
|
|
@gxthrj Please take a look when you have time. |
| Methods []string `json:"methods"` | ||
| Priority int `json:"priority"` | ||
| Plugins map[string]interface{} `json:"plugins"` | ||
| UpstreamId string `json:"upstream_id"` |
There was a problem hiding this comment.
Generally I like some kind of order in lists, arrays or structures but not sure how this affects the whole system.
So with ordering some people chose an alphabetically ordered list, and others use a custom sort order for maybe the first few items in the list and then alphabetically for the rest of the items in the list. There are many ways to sort and design data structures.
Ordering also makes it easier to find existing items in the lists and speeds up adding new items.
So in this file there seems to be two lists and some other files in this PR have lists.
A general code style comment that I always push.
There was a problem hiding this comment.
The order of fields affects the memory alignment but is not so important here, if that's really vital, we can optimize it in the future.
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Backport patches
Related issues
Bugfix
Description
How to fix?
New feature or improvement
Backport patches
Why need to backport?
Source branch
Related commits and pull requests
Target branch