Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support rewrite annotation #480

Merged
merged 4 commits into from
May 25, 2021
Merged

Conversation

lingsamuel
Copy link
Member

Signed-off-by: Ling Samuel lingsamuelgrace@gmail.com

Please answer these questions before submitting a pull request

  • Why submit this pull request?

  • Bugfix

  • New feature provided

  • Improve performance

  • Backport patches

  • Related issues


New feature or improvement

  • Describe the details and related test reports.

Support rewrite request by annotation.

Note: because regex may contains comma, the regex require two annotations.

Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2021

Codecov Report

Merging #480 (b64bce7) into master (0bdd24b) will decrease coverage by 0.18%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #480      +/-   ##
==========================================
- Coverage   37.04%   36.86%   -0.19%     
==========================================
  Files          47       48       +1     
  Lines        3841     3860      +19     
==========================================
  Hits         1423     1423              
- Misses       2233     2252      +19     
  Partials      185      185              
Impacted Files Coverage Δ
pkg/kube/translation/annotations.go 36.36% <ø> (ø)
pkg/kube/translation/annotations/rewrite.go 0.00% <0.00%> (ø)
pkg/apisix/cluster.go 26.69% <0.00%> (-0.35%) ⬇️
pkg/ingress/controller.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bdd24b...b64bce7. Read the comment docs.

@tokers
Copy link
Contributor

tokers commented May 24, 2021

@lingsamuel All files should carry the Apache License Header.

Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
@gxthrj gxthrj merged commit 1d7b143 into apache:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants