-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support rewrite annotation #480
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #480 +/- ##
==========================================
- Coverage 37.04% 36.86% -0.19%
==========================================
Files 47 48 +1
Lines 3841 3860 +19
==========================================
Hits 1423 1423
- Misses 2233 2252 +19
Partials 185 185
Continue to review full report at Codecov.
|
@lingsamuel All files should carry the Apache License Header. |
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
tokers
reviewed
May 24, 2021
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
tokers
approved these changes
May 24, 2021
gxthrj
reviewed
May 24, 2021
gxthrj
reviewed
May 24, 2021
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
gxthrj
approved these changes
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ling Samuel lingsamuelgrace@gmail.com
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Backport patches
Related issues
New feature or improvement
Support rewrite request by annotation.
Note: because regex may contains comma, the regex require two annotations.