feat: add logic for ApisixRoute v2beta1 #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #576 +/- ##
==========================================
+ Coverage 35.03% 35.40% +0.37%
==========================================
Files 54 54
Lines 4556 5332 +776
==========================================
+ Hits 1596 1888 +292
- Misses 2742 3222 +480
- Partials 218 222 +4 ☔ View full report in Codecov by Sentry. |
tokers
reviewed
Jul 7, 2021
tokers
reviewed
Jul 10, 2021
pkg/kube/translation/util.go
Outdated
| return "", 0, err | ||
| } | ||
|
|
||
| if backend.ResolveGranularity == "service" && svc.Spec.ClusterIP == "" { |
There was a problem hiding this comment.
This check can be put before the for loop?
There was a problem hiding this comment.
Yep, I moved them to the line before loop, and ditto with the other two versions.
tokers
approved these changes
Jul 10, 2021
tao12345666333
approved these changes
Jul 10, 2021
fgksgf
pushed a commit
to fgksgf/apisix-ingress-controller
that referenced
this pull request
Aug 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Backport patches
Related issues
feat: Support UDP definition #116 feat: support udp route #396
Bugfix
Description
How to fix?
New feature or improvement
Backport patches
Why need to backport?
Source branch
Related commits and pull requests
Target branch