-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: route crd add timeout fields #609
Conversation
Codecov Report
@@ Coverage Diff @@
## master #609 +/- ##
==========================================
+ Coverage 34.40% 34.47% +0.07%
==========================================
Files 55 57 +2
Lines 5468 5734 +266
==========================================
+ Hits 1881 1977 +96
- Misses 3362 3510 +148
- Partials 225 247 +22
Continue to review full report at Codecov.
|
@@ -99,6 +100,7 @@ type ApisixRouteHTTP struct { | |||
Backends []*ApisixRouteHTTPBackend `json:"backends" yaml:"backends"` | |||
Websocket bool `json:"websocket" yaml:"websocket"` | |||
Plugins []*ApisixRouteHTTPPlugin `json:"plugins,omitempty" yaml:"plugins,omitempty"` | |||
PluginConfigID string `json:"plugin_config_id,omitempty" yaml:"plugin_config_id,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO this is a terrible way to expose the ID of an APISIX configuration in the declarative configuration way, it's not easy for people to configure it.
Another CRD to group a bunch of plugins can be introduced, say ApisixPluginConfig
, and here we should specify the name of such CR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can split into two PR
- add Timeout
- add PluginConfig CR (this feature need to be discuss in mail list https://lists.apache.org/list.html?dev@apisix.apache.org)
@Donghui0 please check the unit-test errors. https://github.com/apache/apisix-ingress-controller/pull/609/checks?check_run_id=3358610706 |
This error is that the time to run the unit test exceeds the default 10 minutes. Is it due to a remote host configuration problem? For example: When I submit the code, there are other tasks occupying resources that cause resource contention, which causes the unit test task to run out of time ? There is no error when running |
@Donghui0 yep, I re-run the job,no more errors. |
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Backport patches
Related issues
New feature or improvement
Route.Spec add plugin_config_id And timeout fields.
Backport patches
Why need to backport?
Source branch
Related commits and pull requests
Target branch