feat: add webhooks for consumer/tls/upstream

[fgksgf]

Please answer these questions before submitting a pull request

• Why submit this pull request?

• Bugfix

• New feature provided

• Improve performance

• Backport patches

• Related issues

---

New feature or improvement

• Describe the details and related test reports.

Add webhooks for consumer/tls/upstream.

TODO

• add webhooks
• add e2e test cases
• update helm chart

[codecov-commenter]

Codecov Report

Merging #667 (c0f5291) into master (6a8658d) will decrease coverage by 0.25%.
The diff coverage is 28.42%.

❗ Current head c0f5291 differs from pull request most recent head d0b1f9e. Consider uploading reports for the commit d0b1f9e to get more accurate results

@@            Coverage Diff             @@
##           master     #667      +/-   ##
==========================================
- Coverage   34.77%   34.51%   -0.26%     
==========================================
  Files          60       63       +3     
  Lines        5916     6078     +162     
==========================================
+ Hits         2057     2098      +41     
- Misses       3608     3729     +121     
  Partials      251      251              

Impacted Files	Coverage Δ
pkg/api/validation/apisix_consumer.go	0.00% <0.00%> (ø)
pkg/api/validation/apisix_tls.go	0.00% <0.00%> (ø)
pkg/api/validation/apisix_upstream.go	0.00% <0.00%> (ø)
pkg/apisix/apisix.go	67.50% <ø> (ø)
pkg/apisix/nonexistentclient.go	41.79% <0.00%> (-0.64%)	⬇️
pkg/ingress/apisix_consumer.go	0.00% <0.00%> (ø)
pkg/ingress/apisix_tls.go	0.00% <0.00%> (ø)
pkg/ingress/controller.go	1.06% <0.00%> (-0.01%)	⬇️
pkg/ingress/endpoint.go	0.00% <0.00%> (ø)
pkg/ingress/endpointslice.go	0.00% <0.00%> (ø)
... and 10 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a8658d...d0b1f9e. Read the comment docs.

[fgksgf]

I just found that there is already basic validation in CRDs, so could you provide some cases that can not be validated in CRD, then I will replace the logic in webhooks with yours.

[tao12345666333]

@fgksgf you can just fix the lint error. then we can move forward.

[fgksgf]

@fgksgf you can just fix the lint error. then we can move forward.

I just didn't figure out why the linter report the error:

There is no lint errors when I run make lint locally.

[tao12345666333]

@fgksgf I think, it's a GitHub Action's bug.

I have trigerd it on my fork using same env. It can be pass. https://github.com/tao12345666333/ingress-controller/runs/3684766821?check_suite_focus=true

[tao12345666333]

We can skip the lint error.
WDYT? @gxthrj @tokers

[tokers]

We can skip the lint error.
WDYT? @gxthrj @tokers

Agree, we already have our own lints.

[gxthrj]

Yes, I have checked the lint too, it can pass.

If there is no other need to modify, we can merge this PR. cc @tao12345666333 @tokers @lingsamuel

[lingsamuel]

+1 can't repro. I triggered it again, let's see if it will pass. If not, we may need to create an ignore rule.

[tao12345666333]

+1

[tao12345666333]

ApisixRoute v2beta2 version was introduced in #698
The corresponding check was not covered in this PR.

Let's merge this PR first, and then increase the coverage of v2beta2 in subsequent PRs.

[tao12345666333]

Added a new issue for tracking #703