Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add v2beta3 register resources #833

Merged
merged 3 commits into from
Jan 11, 2022

Conversation

tao12345666333
Copy link
Member

@tao12345666333 tao12345666333 commented Jan 6, 2022

Signed-off-by: Jintao Zhang zhangjintao9020@gmail.com

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

Using register-gen tool to generate register.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2022

Codecov Report

Merging #833 (92afdd9) into master (8364821) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #833      +/-   ##
==========================================
- Coverage   32.13%   32.09%   -0.05%     
==========================================
  Files          70       71       +1     
  Lines        7726     7721       -5     
==========================================
- Hits         2483     2478       -5     
  Misses       4968     4968              
  Partials      275      275              
Impacted Files Coverage Δ
pkg/config/config.go 64.64% <0.00%> (-1.38%) ⬇️
cmd/ingress/ingress.go 77.55% <0.00%> (-0.45%) ⬇️
test/e2e/e2e.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8364821...92afdd9. Read the comment docs.

Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@tao12345666333 tao12345666333 requested a review from starsz January 6, 2022 08:50
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@gxthrj gxthrj merged commit 3040cf5 into apache:master Jan 11, 2022
@tao12345666333 tao12345666333 deleted the fix-v2beta3-resource branch January 11, 2022 07:19
tao12345666333 added a commit to tao12345666333/ingress-controller that referenced this pull request Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants