-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: controller err handler should ignore not found error #893
fix: controller err handler should ignore not found error #893
Conversation
Codecov Report
@@ Coverage Diff @@
## master #893 +/- ##
==========================================
- Coverage 32.05% 31.71% -0.34%
==========================================
Files 71 72 +1
Lines 7775 7861 +86
==========================================
+ Hits 2492 2493 +1
- Misses 5009 5094 +85
Partials 274 274
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, should ignore the NOT FOUND error.
Please resolve conflicts. Thanks! @lingsamuel |
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
308cba1
to
c41dad4
Compare
@tao12345666333 done |
Signed-off-by: Ling Samuel lingsamuelgrace@gmail.com
Type of change:
What this PR does / why we need it:
Fixes: #810