fix: fix up ep resourceVersion comparison and clean up #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tao12345666333
requested review from
gxthrj,
tokers,
tao12345666333 and
lingsamuel
Codecov Report
@@ Coverage Diff @@
## master #901 +/- ##
=======================================
Coverage 32.05% 32.05%
=======================================
Files 71 71
Lines 7775 7775
=======================================
Hits 2492 2492
Misses 5009 5009
Partials 274 274
Continue to review full report at Codecov.
|
tao12345666333
approved these changes
Mar 7, 2022
nayihz
commented
Mar 7, 2022
| @@ -28,7 +28,6 @@ import ( | |||
| networkingv1beta1 "k8s.io/api/networking/v1beta1" | |||
| "k8s.io/apimachinery/pkg/api/meta" | |||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | |||
| v1 "k8s.io/apimachinery/pkg/apis/meta/v1" | |||
lingsamuel
approved these changes
Mar 7, 2022
|
updated: apisixTls/ endpointSlice/ secret aslo have this problem. |
|
good catch. |
gxthrj
approved these changes
Mar 7, 2022
lingsamuel
approved these changes
Mar 7, 2022
|
maybe need to re-run e2e-test😂 @tao12345666333 |
|
re-run CI. |
|
It's green! Thanks! |
tao12345666333
pushed a commit
to tao12345666333/ingress-controller
that referenced
this pull request
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change:
What this PR does / why we need it:
Pre-submission checklist:
fix #806 (comment)