-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add e2e test for serverless plugin #964
feat: add e2e test for serverless plugin #964
Conversation
Codecov Report
@@ Coverage Diff @@
## master #964 +/- ##
=======================================
Coverage 31.75% 31.75%
=======================================
Files 72 72
Lines 7935 7935
=======================================
Hits 2520 2520
Misses 5139 5139
Partials 276 276 Continue to review full report at Codecov.
|
You can just create one ApisixRoute resource, and enable the serverless plugin. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
test/e2e/suite-plugins/serverless.go
Outdated
backends: | ||
- serviceName: %s | ||
servicePort: %d | ||
weight: 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need this line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it.
test/e2e/suite-plugins/serverless.go
Outdated
backends: | ||
- serviceName: %s | ||
servicePort: %d | ||
weight: 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Type of change:
What this PR does / why we need it:
Add e2e test for serverless plugin!
Pre-submission checklist: