Skip to content

bug: On applying any ext-plugin-post-resp, any header set by upstream service was not passed to downstream #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abhi0476 opened this issue Jul 11, 2023 · 4 comments

Comments

@abhi0476
Copy link

If we apply any ext-plugin-post-resp filter any header set by upstream service was not passed to downstream.

Also There is no provision for setting multiple headers as headers is made as private Map<String, String> headers; instead it should be private Map<String, List> headers in PostResponse.java and PostRequest.java

Environment

  • apisix-runner-starter 0.4.0

Minimal test code / Steps to reproduce the issue

  1. Apply any developed filter on ext-plugin-post-resp
  2. Set some header say cookie on upstream server
  3. Check response on httpclient, upstream headers has been ommitted

What's the actual result? (including assertion message & call stack if applicable)

Headers is not available on downstream

What's the expected result?

Headers should be available on downstream

Attaching a fix for the same
apisix.zip

@moonming moonming moved this to 🏗 In progress in ⚡️ Apache APISIX Roadmap Jul 11, 2023
@moonming moonming moved this from 🏗 In progress to 👀 In review in ⚡️ Apache APISIX Roadmap Jul 11, 2023
@Sn0rt
Copy link

Sn0rt commented Jul 13, 2023

thx you very much. and can you create a PR ?

@abhi0476
Copy link
Author

thx you very much. and can you create a PR ?
How to do that? In which branch should I commit and push first?

@juzhiyuan
Copy link
Member

Hi @abhi0476,

  1. You need to click fork at https://github.com/apache/apisix-java-plugin-runner
  2. Commit changes to the main branch
  3. Submit a PR

abhi0476 added a commit to abhi0476/apisix-java-plugin-runner that referenced this issue Jul 14, 2023
@abhi0476
Copy link
Author

Hi @abhi0476,

  1. You need to click fork at https://github.com/apache/apisix-java-plugin-runner
  2. Commit changes to the main branch
  3. Submit a PR

Done

abhi0476 added a commit to abhi0476/apisix-java-plugin-runner that referenced this issue Jul 18, 2023
abhi0476 added a commit to abhi0476/apisix-java-plugin-runner that referenced this issue Jul 18, 2023
Test case fixes
abhi0476 added a commit to abhi0476/apisix-java-plugin-runner that referenced this issue Aug 9, 2023
abhi0476 added a commit to abhi0476/apisix-java-plugin-runner that referenced this issue Aug 9, 2023
abhi0476 added a commit to abhi0476/apisix-java-plugin-runner that referenced this issue Aug 9, 2023
abhi0476 added a commit to abhi0476/apisix-java-plugin-runner that referenced this issue Aug 17, 2023
@Revolyssup Revolyssup moved this from 👀 In review to 🏗 In progress in ⚡️ Apache APISIX Roadmap Nov 1, 2023
@Baoyuantop Baoyuantop moved this from 🏗 In progress to 📋 Backlog in ⚡️ Apache APISIX Roadmap Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

No branches or pull requests

3 participants