Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature required: place the plugin icon image horizontal center in plugins page #484

Closed
liuxiran opened this issue Aug 19, 2021 · 2 comments · Fixed by #501
Closed

Feature required: place the plugin icon image horizontal center in plugins page #484

liuxiran opened this issue Aug 19, 2021 · 2 comments · Fixed by #501

Comments

@liuxiran
Copy link
Contributor

In addition, maybe it would look better by placing the plugin icon image horizontal center

Agreed, they are not centered completely, feel free to solve this issue. Also one more thing if you could help out with would be really nice , can you reduce the sizes of the plugin thumbnails so that all of them look of the same sizes and bit smaller (currently the icons seem too packed inside the card with less white space all around)

Originally posted by @1502shivam-singh in #478 (comment)
@liuxiran liuxiran mentioned this issue Aug 19, 2021
Merged
@foolwc
Copy link
Contributor

foolwc commented Aug 19, 2021 •
edited by liuxiran
Loading

I'm glad to do it.

  • place the plugin thumbnails in horizontal center;
  • reduce the sizes of the plugin thumbnails;

@juzhiyuan
Copy link
Member

would better provide a design only :)

This was referenced Aug 19, 2021
Merged
Merged
SkyeYoung pushed a commit to SkyeYoung/apisix-website that referenced this issue Mar 3, 2022
@nic-chen @ShiningRush @moonming
feat: refactor manager api (apache#564)
a1f96d4 
* feat: refactor some codes and append store core

* refference droplet and write a API demo

* fmt project

* feat: add validator for generic store; add demo error

* feat: upgrade droplet

* chore: add structures (apache#484)

* add upstream struct

* fix structures

* feat: append stock check for generic store

* feat: add consumer CURD refactoring (apache#486)

* feat: add consumer CURD refactoring

* remove debug

* remove useless slashes

* feat: add SSL refactoring (apache#488)

Co-authored-by: Vinci Xu <277040271@qq.com>

* feat: add Service and Upstream refactoring (apache#497)

* feat: add Service and Upstream refactoring

* fix add license

* feat: add store hub and flake id (apache#534)

* feat: add store hub and flake id

* feat: add store interface to easy est

* fix: add test cases for refactored apis and fix bugs (apache#528)

* test: delete mysql version test cases.

* fix: add ssl test cases and bug fix

* fix: list api should return an empty array not a null for client

* test: consumer test cases

* fix: code style

* test: init etcd in github action

* fix: skip checking generated file's license

* feat: add store hub and flake id (apache#534)

* feat: add store hub and flake id

* feat: add store interface to easy est

* fix CI failed

Co-authored-by: Vinci Xu <277040271@qq.com>

* feat: refactor apis for existing check and other apis (apache#535)

* fix code style

* fix code style

* feat support query

* feat: support query

* change: `like` to `equal`

* fix api status

* feat: upstream existing check

* feat: refactor api for upstream names

* fix: license

* test: add unit test cases

* fix: update bug

* test: add test cases for route

* fix: unified respond format

* test: remove test bug

* feat: ssl existing check

* fix bug: auto generate id

* fix: improve consumer

* fix: remove key and keys in ssl respond

* fix: when list is empty, should respond an empty array

* fix code style

* feat: plugin orchestration

* fix delete bug

* fix bug

* fix: keep the same request params and respond with the old format

* fix: append sort for list and using sync.Map instead of map

* feature: sync json schema from APISIX and check schema when create or update resource (apache#551)

* feat: json schema check

* fix: don't need to define struct for each resource, because that may cause json schema check fail.

* test: add handler test cases

* test: complete consumer test cases

* test: add test cases for schema check

* fix code style and license

* feat: add schema check for plugins

* test: add ssl handler test cases

* test: add test cases for upstream and service

* test: add test cases for route

* test: add note for route create

* test: update CI

* fix: remove useless file

* test: fix CI

* fix: ci fail

* test: fix lib `dag-to-lua`'s path in CI

* fix: URI for route may be empty

* fix: remove empty lines

* fix: refactor validator of json schema

* fix code style

* fix cicd

* chore: update docker file

* fix: should check schema after id generated

* fix code style

* chore: page_number -> page

* fix: schema sync script

* fix: code style

* feat: support search for resource list (apache#557)

* feat: support search for resource list

* fix ci

* feature: refactor plugin api and auth api (apache#556)

* feat: refactor plugin and healthy api

* feat: refactor authentication api

* fix: remove useless files

* chore: update json schema

* test: add login test

* test: add test for plugin

* fix: license

* fix auth bug

* fix route search by uri

* feat: compatible with PUT method of `admin api` and nodes of upstream (apache#561)

* feat: support labels

* feat: compatible with PUT method of `admin api`

* fix mock test fail

* feat: upstream nodes format

* test: add test case

* fix code style

* fix: update schema sync tool

* feat: compatible with HTTP status of `admin api` (apache#563)

* feat: compatible with HTTP status of `admin api`

* test cases and improve

* fix: check input.ID before using it

* fix: remove CI branch

* fix: remove useless dependences

* add license for json.lua

* fix license issue

* remove

* fix: remove viper that depend github.com/hashicorp/hcl

* fix license issue

* fix: skip license check temporarily for CI

Co-authored-by: vincixu <vincixu@tencent.com>
Co-authored-by: ShiningRush <277040271@qq.com>
Co-authored-by: WenMing <moonbingbing@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: make plugin hub page plugins icon horizontal center foolwc/apisix-website
3 participants
@juzhiyuan @liuxiran @foolwc