Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Zh Blogs #626

Closed
wants to merge 1 commit into from
Closed

Conversation

KishaniKandasamy
Copy link
Contributor

@KishaniKandasamy KishaniKandasamy commented Sep 23, 2021

Fixes: #623

Changes:

made changes for #470 according to https://www.docusaurus.cn/docs/api/plugins/@docusaurus/plugin-content-blog#i18n

Please review when you are available @juzhiyuan @liuxiran @bzp2010 @Baoyuantop

@Baoyuantop
Copy link
Contributor

Does it seem that no matter if I change Chinese or English, the blog is always displayed in English?

@KishaniKandasamy
Copy link
Contributor Author

Does it seem that no matter if I change Chinese or English, the blog is always displayed in English?

Yes. just rechecked this https://www.docusaurus.cn/docs/api/plugins/@docusaurus/plugin-content-blog#i18n .
Please let me know if there is any change to be done.

@Baoyuantop
Copy link
Contributor

In #623, the Expected Behaviour is:
When the current environment is in English, only English blogs are displayed, and in the Chinese environment, only Chinese blogs are displayed.

@KishaniKandasamy
Copy link
Contributor Author

KishaniKandasamy commented Sep 25, 2021

In #623, the Expected Behaviour is:
When the current environment is in English, only English blogs are displayed, and in the Chinese environment, only Chinese blogs are displayed.

yes For this behavior I followed this guide https://www.docusaurus.cn/docs/api/plugins/@docusaurus/plugin-content-blog#i18n & will look into that

@KishaniKandasamy
Copy link
Contributor Author

Does it seem that no matter if I change Chinese or English, the blog is always displayed in English?

Yes ;(
Screenshot 2021-09-25 170633

@Baoyuantop
Copy link
Contributor

cc @guoqqqi

@Baoyuantop
Copy link
Contributor

Hi @KishaniKandasamy, In general, there are a few things that need to be changed:

  1. All blog content should both exist in the blog and i18n/zh/docusaurus-plugin-content-blog directories.

  2. Because the website is in English by default, the blogs in the blog directory should all be in English, but we have not yet completed the overall translation, so the Chinese blogs in this directory need to be marked as draft, refer to: https://docusaurus.io/zh-CN/docs/api/plugins/@docusaurus/plugin-content-blog#markdown-frontmatter

  3. Similarly, the blogs in the i18n/zh/docusaurus-plugin-content-blog directory should all be in Chinese, so we need to mark all the English blogs in this directory as draft.

We need to complete the translation of the blog marked as draft in the future, and then cancel the draft mark.

What do you think?

@KishaniKandasamy
Copy link
Contributor Author

KishaniKandasamy commented Sep 28, 2021

Hi @KishaniKandasamy, In general, there are a few things that need to be changed:

  1. All blog content should both exist in the blog and i18n/zh/docusaurus-plugin-content-blog directories.
  2. Because the website is in English by default, the blogs in the blog directory should all be in English, but we have not yet completed the overall translation, so the Chinese blogs in this directory need to be marked as draft, refer to: https://docusaurus.io/zh-CN/docs/api/plugins/@docusaurus/plugin-content-blog#markdown-frontmatter
  3. Similarly, the blogs in the i18n/zh/docusaurus-plugin-content-blog directory should all be in Chinese, so we need to mark all the English blogs in this directory as draft.

We need to complete the translation of the blog marked as draft in the future, and then cancel the draft mark.

What do you think?

I got it @Baoyuantop .Many thanks for this clarification! I'm gonna make this changes :)

@KishaniKandasamy KishaniKandasamy marked this pull request as draft September 29, 2021 11:24
@KishaniKandasamy
Copy link
Contributor Author

Hi @Baoyuantop , I have submitted another PR for this task.

@yzeng25
Copy link
Contributor

yzeng25 commented Oct 18, 2021

Hi @KishaniKandasamy @Baoyuantop , are you guys still working on this PR and #550? Or maybe you can close it since it is done in #634. Thanks!

@KishaniKandasamy
Copy link
Contributor Author

Hi @KishaniKandasamy @Baoyuantop , are you guys still working on this PR and #550? Or maybe you can close it since it is done in #634. Thanks!

Hi @Baoyuantop We can close it :)

@juzhiyuan
Copy link
Member

Hi @KishaniKandasamy, thanks for your continuous contrition! I have translated all necessary blogs in #681 #682 #679 #678 from Chinese to English, so I will close this PR and #550 :)

@juzhiyuan juzhiyuan closed this Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

About the i18n of blogs
4 participants