Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Draft Property to newly added blogs #637

Merged
merged 10 commits into from
Oct 6, 2021
Merged

feat: add Draft Property to newly added blogs #637

merged 10 commits into from
Oct 6, 2021

Conversation

KishaniKandasamy
Copy link
Contributor

Fixes: #623

Changes:
added draft property to newly added blogs

juzhiyuan
juzhiyuan reviewed Oct 3, 2021
View reviewed changes
Copy link
Member

@juzhiyuan juzhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @KishaniKandasamy, I noticed we also have some posts duplicated, do we have to keep them? e.g the release-apache-apisix-2.10.md in Chinese.

@KishaniKandasamy
Copy link
Contributor Author

Hi @KishaniKandasamy, I noticed we also have some posts duplicated, do we have to keep them? e.g the release-apache-apisix-2.10.md in Chinese.

No if both english and chinese translations are done for a blog, then we could remove its duplicate and there is no need to add draft property there.I will check it out and remove them in this PR👍

@KishaniKandasamy
Copy link
Contributor Author

KishaniKandasamy commented Oct 5, 2021 •
edited
Loading

Hi @KishaniKandasamy, I noticed we also have some posts duplicated, do we have to keep them? e.g the release-apache-apisix-2.10.md in Chinese.

No if both english and chinese translations are done for a blog, then we could remove its duplicate and there is no need to add draft property there.I will check it out and remove them in this PR👍

Hi @juzhiyuan the duplicates are removed now

@juzhiyuan
Copy link
Member

Thanks! Need @Baoyuantop @guoqqqi to have a look

@juzhiyuan juzhiyuan merged commit 7b77f0e into apache:master Oct 6, 2021
@yzeng25 yzeng25 mentioned this pull request Oct 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juzhiyuan juzhiyuan juzhiyuan approved these changes

@Baoyuantop Baoyuantop Baoyuantop approved these changes

@LiteSun LiteSun LiteSun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

About the i18n of blogs
4 participants
@KishaniKandasamy @juzhiyuan @Baoyuantop @LiteSun