Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add the DockerHub links on Downloads page #886

Merged
merged 2 commits into from
Feb 21, 2022

Conversation

oil-oil
Copy link
Contributor

@oil-oil oil-oil commented Feb 18, 2022

Fixes: #767

Changes:

Add the DockerHub links on Downloads page.

Screenshots of the change:

image

@netlify
Copy link

netlify bot commented Feb 18, 2022

✔️ Deploy Preview for apache-apisix ready!

🔨 Explore the source changes: 238b2b0

🔍 Inspect the deploy log: https://app.netlify.com/sites/apache-apisix/deploys/6212ec9fcd024f0008c4abba

😎 Browse the preview: https://deploy-preview-886--apache-apisix.netlify.app

juzhiyuan
juzhiyuan previously approved these changes Feb 20, 2022
Copy link
Member

@juzhiyuan juzhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@1502shivam-singh 1502shivam-singh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please resolve the conflicts though

@oil-oil
Copy link
Contributor Author

oil-oil commented Feb 20, 2022

LGTM, please resolve the conflicts though

OK.

@oil-oil oil-oil dismissed stale reviews from 1502shivam-singh and juzhiyuan via 238b2b0 February 21, 2022 01:36
@oil-oil
Copy link
Contributor Author

oil-oil commented Feb 21, 2022

@juzhiyuan Can you help me re-execute the CI, I can pass the test in the development environment.

@oil-oil
Copy link
Contributor Author

oil-oil commented Feb 21, 2022

@yzeng25 Can you help me re-execute the CI, I can pass the test in the development environment.

@yzeng25
Copy link
Contributor

yzeng25 commented Feb 21, 2022

@yzeng25 Can you help me re-execute the CI, I can pass the test in the development environment.

ok, it is up and re-running now.

@yzeng25 yzeng25 merged commit 3c36444 into apache:master Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the DockerHub links on Downloads page
5 participants