correct warning

apache · Apr 4, 2023 · bffbf56 · bffbf56
1 parent 7665604
commit bffbf56
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 3 deletions.
diff --git a/apisix/admin/init.lua b/apisix/admin/init.lua
@@ -405,7 +405,7 @@ function _M.init_worker()
         if local_conf.deployment.admin.admin_key_required == false then
             core.log.warn("Admin key is bypassed! ",
                 "If you are deploying APISIX in a production environment, ",
-                "please disable it and set a secure password for the admin Key!")
+                "please disable `admin_key_required` and set a secure admin key!")
         end
 
         local ok, err = ngx_timer_at(0, function(premature)

diff --git a/apisix/cli/ops.lua b/apisix/cli/ops.lua
@@ -194,7 +194,7 @@ local function init(env)
         checked_admin_key = true
         print("Warning! Admin key is bypassed! "
                 .. "If you are deploying APISIX in a production environment, "
-                .. "please disable it and set a secure password for the admin Key!")
+                .. "please disable `admin_key_required` and set a secure admin key!")
     end
 
     if yaml_conf.apisix.enable_admin and not checked_admin_key then

diff --git a/t/admin/api.t b/t/admin/api.t
@@ -183,7 +183,18 @@ GET /apisix/admin/routes
 
 
 
-=== TEST 12: Access without api key, but admin_key_required=false
+=== TEST 12: Access without api key, but admin_key_required=true
+--- yaml_config
+deployment:
+  admin:
+    admin_key_required: true
+--- request
+GET /apisix/admin/routes
+--- error_code: 200
+
+
+
+=== TEST 13: Access without api key, but admin_key_required=false
 --- yaml_config
 deployment:
   admin: