Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add schema attribute definition for some log plug-ins #10803

Closed
smileby opened this issue Jan 11, 2024 · 3 comments · Fixed by #10888
Closed

feat: Add schema attribute definition for some log plug-ins #10803

smileby opened this issue Jan 11, 2024 · 3 comments · Fixed by #10888

Comments

@smileby
Copy link
Contributor

smileby commented Jan 11, 2024

Description

The PR submitted before was #10738, dealing with the problem of #9190 .

Some plug-in related attributes need to be improved, such as include_req_body, include_req_body_expr, include_resp_body, include_resp_body_expr

Current status:

The list of plugins with missing attributes is as follows:

  • skywalking-logger
  • tcp-logger
  • udp-logger
  • syslog
  • sls-logger
  • elasticsearch-logger
  • splunk-hec-logging
  • google-cloud-logging

expect:

Supplement the above plug-ins. Temporarily skip the following two plug-ins:

  • splunk-hec-logging
  • google-cloud-logging

They have a specific format and will not be adjusted for the time being.

@smileby
Copy link
Contributor Author

smileby commented Jan 11, 2024

@shreemaan-abhishek @pottekkat Do I need to extend this function?

@shreemaan-abhishek
Copy link
Contributor

you can submit a PR if you wish to.

@smileby
Copy link
Contributor Author

smileby commented Jan 22, 2024

I will finish it if I have time, I am currently doing other work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants