Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: attributes undocumented for certain logging plugins #9190

Closed
Gallardot opened this issue Mar 29, 2023 · 5 comments · Fixed by #10738
Closed

docs: attributes undocumented for certain logging plugins #9190

Gallardot opened this issue Mar 29, 2023 · 5 comments · Fixed by #10738
Assignees
Labels
doc Documentation things good first issue Good for newcomers

Comments

@Gallardot
Copy link
Member

Gallardot commented Mar 29, 2023

Current State

Thanks to APISIX's excellent design, I found that many logging plug-ins support features such as include_req_body, include_req_body_expr,include_resp_body,include_resp_body_expr, such as file-logger,http-logger,loggly,tencent-cloud-cls. However, this feature does not appear in the plug-in documentation or in the plug-in schema definition.

Desired State

Maybe we should add the above.

@Gallardot Gallardot added the doc Documentation things label Mar 29, 2023
@Neilblaze
Copy link
Contributor

@Gallardot I'm taking this up!

@Gallardot Gallardot changed the title docs: docs: some plug-in configuration item descriptions are missing Mar 29, 2023
@pottekkat
Copy link
Contributor

@Neilblaze Are you still working on this issue?

@Neilblaze Neilblaze removed their assignment May 17, 2023
@Neilblaze
Copy link
Contributor

@navendu-pottekkat Sorry for the delay. I'm working on another issue, so if anyone wants to pick this up, please feel free to assign :)

@kayx23 kayx23 changed the title docs: some plug-in configuration item descriptions are missing docs: attributes undocumented for certain logging plugins Dec 21, 2023
@kayx23 kayx23 added the good first issue Good for newcomers label Dec 21, 2023
@smileby
Copy link
Contributor

smileby commented Dec 26, 2023

@kayx23 can assignees it to me. I'll do it

@pottekkat
Copy link
Contributor

@smileby Thank you. Assigned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation things good first issue Good for newcomers
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants