Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: introduce proxy caching plugin #1127

Closed
agile6v opened this issue Feb 16, 2020 · 2 comments · Fixed by #1153
Closed

Feature: introduce proxy caching plugin #1127

agile6v opened this issue Feb 16, 2020 · 2 comments · Fixed by #1153

Comments

@agile6v
Copy link
Member

agile6v commented Feb 16, 2020

Hi,

I want to introduce a proxy caching plugin, but there are several choices.

  1. Based on Nginx's built-in proxy cache in ngx_http_proxy_module, it store data on disk.
  2. Based on lua_shared_dict in ngx-lua-module, it store data on memory.
  3. Based on external storage such as redis and other redis-like storage system.

Each option has its own scenario, but i think option 1 supports more functionality and less code needs to be implemented. In addition, I'd perfer to abstract these options into a plugin and then by parameters to distinguish.

What do you think of?

@membphis
Copy link
Member

  • Based on Nginx's built-in proxy cache in ngx_http_proxy_module, it store data on disk.

The ngx_http_proxy_module depends on the Nginx configuration file. We need to modify the Nginx core to use it dynamically. This is not an easy task.

  • Based on lua_shared_dict in ngx-lua-module, it store data on memory.

This is the simplest,

@moonming
Copy link
Member

I perfer the option 1, which is more stable and easier to learn.
and one more thing, @agile6v you can send a [DISCUSS] email to mailinglist such like architecture selection topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants