Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Kubernetes discovery determines whether to enable endpointslice #11631

Open
MrLinMH opened this issue Oct 9, 2024 · 2 comments · May be fixed by #11654
Open

bug: Kubernetes discovery determines whether to enable endpointslice #11631

MrLinMH opened this issue Oct 9, 2024 · 2 comments · May be fixed by #11654
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@MrLinMH
Copy link
Contributor

MrLinMH commented Oct 9, 2024

Current Behavior

In the source code, when judging whether to watch endpoint slices, watch_endpoint_slices_schema is used, as follows:
image

But what is defined in the schema is watch_endpoint_slices:
image

When determining whether to watch endpoint slices, you should use conf.watch_endpoint_slices , watch_endpoint_slices_schema is only a local variable in the lua file apisix/discovery/kubernetes/schema.lua . It will not appear in the configuration item schema of discovery kubernetes. The actual variable used in the schema is watch_endpoint_slices .

Expected Behavior

No response

Error Logs

No response

Steps to Reproduce

PR: https://github.com/apache/apisix/pull/10916/files

Environment

APISIX version: 3.9.0 (master branch also has this problem)

@dosubot dosubot bot added the bug Something isn't working label Oct 9, 2024
@nic-chen nic-chen added the good first issue Good for newcomers label Oct 9, 2024
@zhoujiexiong
Copy link
Contributor

zhoujiexiong commented Oct 11, 2024

It looks like the relevant E2E test cases also need further refinement.

@MrLinMH PR to fix the issue?

@slayer321
Copy link

Hey @zhoujiexiong , I did like to work on this issue.
Can you please assign it to me.

@slayer321 slayer321 linked a pull request Oct 15, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Status: 📋 Backlog
Development

Successfully merging a pull request may close this issue.

4 participants