Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable issue of endpointslices for k8s discovery #11654

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: enable issue of endpointslices for k8s discovery #11654

wants to merge 3 commits into from

Conversation

slayer321
Copy link

Description

use conf.watch_endpoint_slices to enable endpointslices whenever it is set to true. Fixed the test.

Fixes #11631

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working doc Documentation things labels Oct 15, 2024
@slayer321
fixes failing endpointslices test when run for the first time, which …
ae7e592 
…now check if the endpointslices variable is of type table
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working doc Documentation things size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Kubernetes discovery determines whether to enable endpointslice
1 participant
@slayer321