Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: failed to get host in health check configuration. #1869

Closed
shuaijinchao opened this issue Jul 19, 2020 · 2 comments · Fixed by #1871
Closed

bug: failed to get host in health check configuration. #1869

shuaijinchao opened this issue Jul 19, 2020 · 2 comments · Fixed by #1871
Assignees
@shuaijinchao
Labels
bug Something isn't working

Comments

@shuaijinchao
Copy link
Member

code location

https://github.com/apache/incubator-apisix/blob/master/apisix/balancer.lua#L64
https://github.com/apache/incubator-apisix/blob/master/apisix/balancer.lua#L95
https://github.com/apache/incubator-apisix/blob/master/apisix/balancer.lua#L198
https://github.com/apache/incubator-apisix/blob/master/apisix/balancer.lua#L201
https://github.com/apache/incubator-apisix/blob/master/apisix/balancer.lua#L206

refer to the health check configuration:
https://github.com/apache/incubator-apisix/blob/master/doc/health-check.md
host should be from checks.active.host instead of checks.host
@membphis
Copy link
Member

you are right, welcome PR to fix it

@membphis membphis added the bug Something isn't working label Jul 20, 2020
@shuaijinchao
Copy link
Member Author

you are right, welcome PR to fix it

OK

@shuaijinchao shuaijinchao self-assigned this Jul 20, 2020
@shuaijinchao shuaijinchao mentioned this issue Jul 20, 2020
Merged
4 tasks
membphis pushed a commit that referenced this issue Jul 27, 2020
@shuaijinchao
bugfix: failed to get host in health check configuration. (#1871)
a108d2e 
The `host` of health check should be sub-item of `check.active` .

FIX #1869
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shuaijinchao shuaijinchao

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bugfix: failed to get host in health check configuration. shuaijinchao/apisix
2 participants
@membphis @shuaijinchao